Finishing the Warblade class

[CapnQ]

I recently got interested in the Warblade class and, on trying it out, discovered that it doesn't work. Looking at it more closely, it appears that it was never finished, so I decided to try to finish it. Here's what was already done:

1) As far as I can tell, the conversation for picking stances and maneuvers works as it should.
2) The Battle Clarity Feat is implemented.
3) The Weapon Aptitude conversation comes up at the right time, but the choices are listed incorrectly and picking one of them doesn't actually do anything.

Here's what I've done so far:

1) Fixed the Weapon Aptitude conversation to give it the right choices and make them actually work.
2) Implemented the Battle Mastery feat.

Now for some questions. I'm not a PnP expert (pretty much all I know about it comes from NWN and NWN2), and I've never created or modified an NWN class before except for my recent changes to the Shifter (PnP) class, so bear with me.

1) The Weapon Aptitude feat was partially implemented. It was trying to simulate Weapon Focus, Weapon Specialization, etc. for the aptitude weapon by adjusting the PC's AB and damage bonuses whenever a weapon was equipped or unequipped. I took a different approach: when a player chooses an aptitude weapon after sleeping, I check if they have the Weapon Focus feat for any weapon and, if so, add a property granting Weapon Focus for the aptitude weapon to their skin; ditto for Weapon Specialization, etc. Advantages to this approach are that it makes checking for weapon equip/unequip unnecessary, and it allows me to apply the Weapon Aptitude feat to feats that would otherwise be difficult to simulate accurately (e.g. Improved Critical with an already Keen weapon). The only disadvantage I can see is that you end up with more feats than you should (e.g. you end up with Weapon Focus in both the aptitude weapon and the weapon you originally chose it for, since there's no way to remove the original feat), but the old approach had the same problem. My question: this approach makes it possible to apply Weapon Aptitude to feats the old implementation didn't attempt: Overwhelming Critical, Devastating Critical, and, I think, Weapon of Choice. Should it?

2) Battle Ardor is supposed to add the INT bonus to the critical threat confirmation roll. Is this possible in NWN1? I know NWN2 has Power Critical, which adds a constant +4 to the threat confirmation roll, but as far as I can tell NWN1 has nothing similar, so I'm thinking it won't be possible. If not, what would be a reasonable substitute?

3) Battle Cunning is supposed to add the INT bonus to damage against flatfooted foes. I haven't thought about this much yet, but does anyone have suggestions how to go about it? Or, if it's not possible, a substitute?

4) Battle Skill is supposed to add the INT bonus to the checks to Trip, Disarm, Overrun, or Bullrush. I'm assuming in NWN Trip/Overrun/Bullrush all translate into Knockdown, and Disarm is Disarm, of course. If there's no easy way to change the check for this (I haven't really looked into this yet), maybe the Battle Skill feat could just be turned into the Improved Knockdown and/or Improved Disarm?

5) Warblade is supposed to qualify for Weapon Specialization (and other fighter specific feats, if any) two levels later than a Fighter would qualify for them. How would this be implemented?

6) I notice in cls_feat_warbld.2da that a lot of feats have GrantedOnLevel set to 99, some others others to -1. I think I've figured out that -1 indicates that the feat should be in the Warblade's Bonus Feat list, but what does 99 indicate?

Sorry for the long post; thanks for any help or suggestions.

[N-S]

I only played with the warblade class for two minutes or so. But I hope I can be of some help.

1) Fixed the Weapon Aptitude conversation to give it the right choices and make them actually work.

Do you mean fixing the weapon names in the dialog? It was broken when I used it.

1) The Weapon Aptitude feat was partially implemented. It was trying to simulate Weapon Focus, Weapon Specialization, etc. for the aptitude weapon by adjusting the PC's AB and damage bonuses whenever a weapon was equipped or unequipped. I took a different approach: when a player chooses an aptitude weapon after sleeping, I check if they have the Weapon Focus feat for any weapon and, if so, add a property granting Weapon Focus for the aptitude weapon to their skin; ditto for Weapon Specialization, etc. Advantages to this approach are that it makes checking for weapon equip/unequip unnecessary, and it allows me to apply the Weapon Aptitude feat to feats that would otherwise be difficult to simulate accurately (e.g. Improved Critical with an already Keen weapon).

Assuming nothing is being overlooked here that seems to be a better choice.

My question: this approach makes it possible to apply Weapon Aptitude to feats the old implementation didn't attempt: Overwhelming Critical, Devastating Critical, and, I think, Weapon of Choice. Should it?

If the DnD feat definition says it changes all weapon-based feats, I'd say yes. Probably even class specific feats too.

2) Battle Ardor is supposed to add the INT bonus to the critical threat confirmation roll. Is this possible in NWN1? I know NWN2 has Power Critical, which adds a constant +4 to the threat confirmation roll, but as far as I can tell NWN1 has nothing similar, so I'm thinking it won't be possible. If not, what would be a reasonable substitute?

Nope. I think you would need to do something crazy like disable the Bioware critical system while replacing it with a script-based one.

3) Battle Cunning is supposed to add the INT bonus to damage against flatfooted foes. I haven't thought about this much yet, but does anyone have suggestions how to go about it? Or, if it's not possible, a substitute?

Should be able to use GetIsInCombat() for this.

4) Battle Skill is supposed to add the INT bonus to the checks to Trip, Disarm, Overrun, or Bullrush. I'm assuming in NWN Trip/Overrun/Bullrush all translate into Knockdown, and Disarm is Disarm, of course. If there's no easy way to change the check for this (I haven't really looked into this yet), maybe the Battle Skill feat could just be turned into the Improved Knockdown and/or Improved Disarm?

I don't think there's a way to hook into those feats.

5) Warblade is supposed to qualify for Weapon Specialization (and other fighter specific feats, if any) two levels later than a Fighter would qualify for them. How would this be implemented?

I'm not sure if you can add feat level-requirements to multiple classes. So maybe remove the requirement and verify it by script (but then they will see this feat even when they don't qualify) or duplicate the specialization feats for the warblade class.

6) I notice in cls_feat_warbld.2da that a lot of feats have GrantedOnLevel set to 99, some others others to -1. I think I've figured out that -1 indicates that the feat should be in the Warblade's Bonus Feat list, but what does 99 indicate?

-1 seems to grant/list the feat regardless of class level. I think 99 is only used to change the OnMenu option. (Are there other reasons to do this, anyone?)


P.S.: A suggestion: Can you change the aptitude dialog to either be activated by feat use or by a PRC Options entry? It was really annoying being prompted after rest.

[Drammel]

1) The Weapon Aptitude feat was partially implemented. It was trying to simulate Weapon Focus, Weapon Specialization, etc. for the aptitude weapon by adjusting the PC's AB and damage bonuses whenever a weapon was equipped or unequipped. I took a different approach: when a player chooses an aptitude weapon after sleeping, I check if they have the Weapon Focus feat for any weapon and, if so, add a property granting Weapon Focus for the aptitude weapon to their skin; ditto for Weapon Specialization, etc. Advantages to this approach are that it makes checking for weapon equip/unequip unnecessary, and it allows me to apply the Weapon Aptitude feat to feats that would otherwise be difficult to simulate accurately (e.g. Improved Critical with an already Keen weapon). The only disadvantage I can see is that you end up with more feats than you should (e.g. you end up with Weapon Focus in both the aptitude weapon and the weapon you originally chose it for, since there's no way to remove the original feat), but the old approach had the same problem. My question: this approach makes it possible to apply Weapon Aptitude to feats the old implementation didn't attempt: Overwhelming Critical, Devastating Critical, and, I think, Weapon of Choice. Should it?

2) Battle Ardor is supposed to add the INT bonus to the critical threat confirmation roll. Is this possible in NWN1? I know NWN2 has Power Critical, which adds a constant +4 to the threat confirmation roll, but as far as I can tell NWN1 has nothing similar, so I'm thinking it won't be possible. If not, what would be a reasonable substitute?

3) Battle Cunning is supposed to add the INT bonus to damage against flatfooted foes. I haven't thought about this much yet, but does anyone have suggestions how to go about it? Or, if it's not possible, a substitute?

4) Battle Skill is supposed to add the INT bonus to the checks to Trip, Disarm, Overrun, or Bullrush. I'm assuming in NWN Trip/Overrun/Bullrush all translate into Knockdown, and Disarm is Disarm, of course. If there's no easy way to change the check for this (I haven't really looked into this yet), maybe the Battle Skill feat could just be turned into the Improved Knockdown and/or Improved Disarm?

5) Warblade is supposed to qualify for Weapon Specialization (and other fighter specific feats, if any) two levels later than a Fighter would qualify for them. How would this be implemented?

6) I notice in cls_feat_warbld.2da that a lot of feats have GrantedOnLevel set to 99, some others others to -1. I think I've figured out that -1 indicates that the feat should be in the Warblade's Bonus Feat list, but what does 99 indicate?

Sorry for the long post; thanks for any help or suggestions.

I've actually been working on a conversion of the Tome of Battle for Neverwinter Nights 2 and finished Warblade class features some time ago.  Here's what I did, but take it with a grain of salt as some of the scripting functionality of NWN2 doesn't exist in NWN.

1.  Did it almost the exact same way as what you're describing, only I used an active feat with a daily recharge.  The script when activated checks the weapon that the player has equipped in their right hand and checks the player's current family of Weapon Focus, Specialization and so forth.  A lot of checks are made and all of the family of feats that the player previously had are switched to the weapon's family of feats as the old are removed.

2.  This one I did the hard way.  The really, really hard way.  I needed to rebuild the entire combat engine (attack and damage rolls, animation, sounds, the works) so that I could implement strikes correctly.  So, having my own version of the combat engine at hand made it simple to modify the crit confirm bonus for strikes, however not basic attacks.  Cursed hardcode.  

Anyway, the solution I came up with was to run a recursive function ( Or a function that calls itself, usually with a DelayCommand, many bardsongs in NWN2 follow this structure), from the feat that checks if the player is in combat.  If the player is in combat, every other round the script runs my attack roll routines.  On that attack roll I apply the Int mod to crit confirmation.  I only do it half the time because essentially I'm making a separate attack roll each round, which is like rolling twice to see if I get a critical hit.  Only if my attack roll confirms a critical hit does it apply damage, and that only for the crit itself, not the full amount for the attack.  Long story short, over time the damage averages out to an amount equal to directly adding to the critical confirmation modifier.

3.  Again, the magic of recursive scripts comes to the rescue.  If you're in combat (targeting them) and they are not, apply an attack bonus.

4.  There's also Feint, but I can't recall if you have that in NWN.  You do have Discipline though which is direct counter to many of these.  Set a skill reduction effect on the pertinent skills that can influence these rolls.  Knockdown and Disarm are much trickier because you cannot directly influence these rolls.  However, NWN treats them as feats, and those you can add and remove with scripting.  For these, I rebuilt the Knockdown and Disarm rules, adding in the Int mod when appropriate.  The thinking behind this is that if I can't directly influence the engine's rolls I can reproduce them, and then remove the feats for a round when my rolls indicate I should.  This script is also run every round of combat because we're influencing the probability that and opponent can use Knockdown or Disarm.  If it isn't there that round they can't use it.  It's complicated, but it does work to achieve the same result as if we were able to directly influence the engine's roll.

5.  For this I edited feat.2da so that that Weapon Specialization and the like requires a proficiency feat of the same name, then I added those proficiency feats to the fighter and warblade class feat 2das at the appropriate levels.  Incidentally, this makes it so that any class with the proficiency feat can take weapon specialization and the like, should you desire to add the proficiency feats to their class feat 2da.

Hope some of this helps out.

[CapnQ]

I only played with the warblade class for two minutes or so. But I hope I can be of some help.

1) Fixed the Weapon Aptitude conversation to give it the right choices and make them actually work.

Do you mean fixing the weapon names in the dialog? It was broken when I used it.

That's part of what I mean. I also mean that, once I fixed the text, I realized not all of the appropriate options were being listed. I also mean that when you picked one of the choices, it didn't actually do anything.

1) The Weapon Aptitude feat was partially implemented. It was trying to simulate Weapon Focus, Weapon Specialization, etc. for the aptitude weapon by adjusting the PC's AB and damage bonuses whenever a weapon was equipped or unequipped. I took a different approach: when a player chooses an aptitude weapon after sleeping, I check if they have the Weapon Focus feat for any weapon and, if so, add a property granting Weapon Focus for the aptitude weapon to their skin; ditto for Weapon Specialization, etc. Advantages to this approach are that it makes checking for weapon equip/unequip unnecessary, and it allows me to apply the Weapon Aptitude feat to feats that would otherwise be difficult to simulate accurately (e.g. Improved Critical with an already Keen weapon).

Assuming nothing is being overlooked here that seems to be a better choice.

My question: this approach makes it possible to apply Weapon Aptitude to feats the old implementation didn't attempt: Overwhelming Critical, Devastating Critical, and, I think, Weapon of Choice. Should it?

If the DnD feat definition says it changes all weapon-based feats, I'd say yes. Probably even class specific feats too.

The way I read it, it does. See http://www.wizards.com/default.asp?x=dnd/ex/20060802a&page=2: "Each morning, you can spend 1 hour in weapon practice to change the designated weapon for any feat you have that applies only to a single weapon (such as Weapon Focus)". What I was really wondering, however, is whether anyone thought this was too much for one level of a class.

2) Battle Ardor is supposed to add the INT bonus to the critical threat confirmation roll. Is this possible in NWN1? I know NWN2 has Power Critical, which adds a constant +4 to the threat confirmation roll, but as far as I can tell NWN1 has nothing similar, so I'm thinking it won't be possible. If not, what would be a reasonable substitute?

Nope. I think you would need to do something crazy like disable the Bioware critical system while replacing it with a script-based one.

That's what I thought, which is why I was asking about alternatives. Perhaps I could replace Battle Ardor with Improved Critical? The latter is probably a better feat, but perhaps that could be balanced out by replacing Improved Uncanny Dodge (not available in NWN1) with Uncanny Dodge 2, which is much weaker.

3) Battle Cunning is supposed to add the INT bonus to damage against flatfooted foes. I haven't thought about this much yet, but does anyone have suggestions how to go about it? Or, if it's not possible, a substitute?

Should be able to use GetIsInCombat() for this.

Thanks, I'll look into that.

4) Battle Skill is supposed to add the INT bonus to the checks to Trip, Disarm, Overrun, or Bullrush. I'm assuming in NWN Trip/Overrun/Bullrush all translate into Knockdown, and Disarm is Disarm, of course. If there's no easy way to change the check for this (I haven't really looked into this yet), maybe the Battle Skill feat could just be turned into the Improved Knockdown and/or Improved Disarm?

I don't think there's a way to hook into those feats.

5) Warblade is supposed to qualify for Weapon Specialization (and other fighter specific feats, if any) two levels later than a Fighter would qualify for them. How would this be implemented?

I'm not sure if you can add feat level-requirements to multiple classes. So maybe remove the requirement and verify it by script (but then they will see this feat even when they don't qualify) or duplicate the specialization feats for the warblade class.

6) I notice in cls_feat_warbld.2da that a lot of feats have GrantedOnLevel set to 99, some others others to -1. I think I've figured out that -1 indicates that the feat should be in the Warblade's Bonus Feat list, but what does 99 indicate?

-1 seems to grant/list the feat regardless of class level. I think 99 is only used to change the OnMenu option. (Are there other reasons to do this, anyone?)


P.S.: A suggestion: Can you change the aptitude dialog to either be activated by feat use or by a PRC Options entry? It was really annoying being prompted after rest.

I was thinking of doing something like this--I agree that it's annoying--but I'd like to get everything more or less working first.

[CapnQ]

1) The Weapon Aptitude feat was partially implemented. It was trying to simulate Weapon Focus, Weapon Specialization, etc. for the aptitude weapon by adjusting the PC's AB and damage bonuses whenever a weapon was equipped or unequipped. I took a different approach: when a player chooses an aptitude weapon after sleeping, I check if they have the Weapon Focus feat for any weapon and, if so, add a property granting Weapon Focus for the aptitude weapon to their skin; ditto for Weapon Specialization, etc. Advantages to this approach are that it makes checking for weapon equip/unequip unnecessary, and it allows me to apply the Weapon Aptitude feat to feats that would otherwise be difficult to simulate accurately (e.g. Improved Critical with an already Keen weapon). The only disadvantage I can see is that you end up with more feats than you should (e.g. you end up with Weapon Focus in both the aptitude weapon and the weapon you originally chose it for, since there's no way to remove the original feat), but the old approach had the same problem. My question: this approach makes it possible to apply Weapon Aptitude to feats the old implementation didn't attempt: Overwhelming Critical, Devastating Critical, and, I think, Weapon of Choice. Should it?

2) Battle Ardor is supposed to add the INT bonus to the critical threat confirmation roll. Is this possible in NWN1? I know NWN2 has Power Critical, which adds a constant +4 to the threat confirmation roll, but as far as I can tell NWN1 has nothing similar, so I'm thinking it won't be possible. If not, what would be a reasonable substitute?

3) Battle Cunning is supposed to add the INT bonus to damage against flatfooted foes. I haven't thought about this much yet, but does anyone have suggestions how to go about it? Or, if it's not possible, a substitute?

4) Battle Skill is supposed to add the INT bonus to the checks to Trip, Disarm, Overrun, or Bullrush. I'm assuming in NWN Trip/Overrun/Bullrush all translate into Knockdown, and Disarm is Disarm, of course. If there's no easy way to change the check for this (I haven't really looked into this yet), maybe the Battle Skill feat could just be turned into the Improved Knockdown and/or Improved Disarm?

5) Warblade is supposed to qualify for Weapon Specialization (and other fighter specific feats, if any) two levels later than a Fighter would qualify for them. How would this be implemented?

6) I notice in cls_feat_warbld.2da that a lot of feats have GrantedOnLevel set to 99, some others others to -1. I think I've figured out that -1 indicates that the feat should be in the Warblade's Bonus Feat list, but what does 99 indicate?

Sorry for the long post; thanks for any help or suggestions.

I've actually been working on a conversion of the Tome of Battle for Neverwinter Nights 2 and finished Warblade class features some time ago.  Here's what I did, but take it with a grain of salt as some of the scripting functionality of NWN2 doesn't exist in NWN.

1.  Did it almost the exact same way as what you're describing, only I used an active feat with a daily recharge.  The script when activated checks the weapon that the player has equipped in their right hand and checks the player's current family of Weapon Focus, Specialization and so forth.  A lot of checks are made and all of the family of feats that the player previously had are switched to the weapon's family of feats as the old are removed.

2.  This one I did the hard way.  The really, really hard way.  I needed to rebuild the entire combat engine (attack and damage rolls, animation, sounds, the works) so that I could implement strikes correctly.  So, having my own version of the combat engine at hand made it simple to modify the crit confirm bonus for strikes, however not basic attacks.  Cursed hardcode.  

Anyway, the solution I came up with was to run a recursive function ( Or a function that calls itself, usually with a DelayCommand, many bardsongs in NWN2 follow this structure), from the feat that checks if the player is in combat.  If the player is in combat, every other round the script runs my attack roll routines.  On that attack roll I apply the Int mod to crit confirmation.  I only do it half the time because essentially I'm making a separate attack roll each round, which is like rolling twice to see if I get a critical hit.  Only if my attack roll confirms a critical hit does it apply damage, and that only for the crit itself, not the full amount for the attack.  Long story short, over time the damage averages out to an amount equal to directly adding to the critical confirmation modifier.

3.  Again, the magic of recursive scripts comes to the rescue.  If you're in combat (targeting them) and they are not, apply an attack bonus.

4.  There's also Feint, but I can't recall if you have that in NWN.  You do have Discipline though which is direct counter to many of these.  Set a skill reduction effect on the pertinent skills that can influence these rolls.  Knockdown and Disarm are much trickier because you cannot directly influence these rolls.  However, NWN treats them as feats, and those you can add and remove with scripting.  For these, I rebuilt the Knockdown and Disarm rules, adding in the Int mod when appropriate.  The thinking behind this is that if I can't directly influence the engine's rolls I can reproduce them, and then remove the feats for a round when my rolls indicate I should.  This script is also run every round of combat because we're influencing the probability that and opponent can use Knockdown or Disarm.  If it isn't there that round they can't use it.  It's complicated, but it does work to achieve the same result as if we were able to directly influence the engine's roll.

5.  For this I edited feat.2da so that that Weapon Specialization and the like requires a proficiency feat of the same name, then I added those proficiency feats to the fighter and warblade class feat 2das at the appropriate levels.  Incidentally, this makes it so that any class with the proficiency feat can take weapon specialization and the like, should you desire to add the proficiency feats to their class feat 2da.

Hope some of this helps out.

1. Unfortunately, NWN1 doesn't have the addfeat and removefeat functions, so my implementation can't be as clean as yours.

2&3: Much more work than I'm willing to put into this, I'm afraid--not to mention that my knowledge of DnD rules isn't up to rebuilding the combat engine.

4: NWN1 doesn't have Feint. Also, as I mentioned before, NWN1 doesn't have the removefeat function, so I can't do the tricks you did with Knockdown and Disarm.

5. This sounds like a great idea. Thanks!

[N-S]

1. Unfortunately, NWN1 doesn't have the addfeat and removefeat functions, so my implementation can't be as clean as yours.

Leto it, or let the DM's do the policing. No one's going to care if a person can exploit the aptitude feat in SP or on a non-PW world.

2&3: Much more work than I'm willing to put into this, I'm afraid--not to mention that my knowledge of DnD rules isn't up to rebuilding the combat engine.

#3 is as simple as adding an onhit effect.

4: NWN1 doesn't have Feint. Also, as I mentioned before, NWN1 doesn't have the removefeat function, so I can't do the tricks you did with Knockdown and Disarm.

It shouldn't be too hard to rewrite KD & Disarm. I don't see why you would have to dynamically alter feats. But why? If it's only for a cosmetic feat used by a single class, then don't. It won't be the first feat left out.

[CapnQ]

I recently got interested in the Warblade class and, on trying it out, discovered that it doesn't work. Looking at it more closely, it appears that it was never finished, so I decided to try to finish it. Here's what was already done:

1) As far as I can tell, the conversation for picking stances and maneuvers works as it should.
2) The Battle Clarity Feat is implemented.
3) The Weapon Aptitude conversation comes up at the right time, but the choices are listed incorrectly and picking one of them doesn't actually do anything.

Here's what I've done so far:

1) Fixed the Weapon Aptitude conversation to give it the right choices and make them actually work.
2) Implemented the Battle Mastery feat.

Now for some questions. I'm not a PnP expert (pretty much all I know about it comes from NWN and NWN2), and I've never created or modified an NWN class before except for my recent changes to the Shifter (PnP) class, so bear with me.

1) The Weapon Aptitude feat was partially implemented. It was trying to simulate Weapon Focus, Weapon Specialization, etc. for the aptitude weapon by adjusting the PC's AB and damage bonuses whenever a weapon was equipped or unequipped. I took a different approach: when a player chooses an aptitude weapon after sleeping, I check if they have the Weapon Focus feat for any weapon and, if so, add a property granting Weapon Focus for the aptitude weapon to their skin; ditto for Weapon Specialization, etc. Advantages to this approach are that it makes checking for weapon equip/unequip unnecessary, and it allows me to apply the Weapon Aptitude feat to feats that would otherwise be difficult to simulate accurately (e.g. Improved Critical with an already Keen weapon). The only disadvantage I can see is that you end up with more feats than you should (e.g. you end up with Weapon Focus in both the aptitude weapon and the weapon you originally chose it for, since there's no way to remove the original feat), but the old approach had the same problem. My question: this approach makes it possible to apply Weapon Aptitude to feats the old implementation didn't attempt: Overwhelming Critical, Devastating Critical, and, I think, Weapon of Choice. Should it?

2) Battle Ardor is supposed to add the INT bonus to the critical threat confirmation roll. Is this possible in NWN1? I know NWN2 has Power Critical, which adds a constant +4 to the threat confirmation roll, but as far as I can tell NWN1 has nothing similar, so I'm thinking it won't be possible. If not, what would be a reasonable substitute?

3) Battle Cunning is supposed to add the INT bonus to damage against flatfooted foes. I haven't thought about this much yet, but does anyone have suggestions how to go about it? Or, if it's not possible, a substitute?

4) Battle Skill is supposed to add the INT bonus to the checks to Trip, Disarm, Overrun, or Bullrush. I'm assuming in NWN Trip/Overrun/Bullrush all translate into Knockdown, and Disarm is Disarm, of course. If there's no easy way to change the check for this (I haven't really looked into this yet), maybe the Battle Skill feat could just be turned into the Improved Knockdown and/or Improved Disarm?

5) Warblade is supposed to qualify for Weapon Specialization (and other fighter specific feats, if any) two levels later than a Fighter would qualify for them. How would this be implemented?

6) I notice in cls_feat_warbld.2da that a lot of feats have GrantedOnLevel set to 99, some others others to -1. I think I've figured out that -1 indicates that the feat should be in the Warblade's Bonus Feat list, but what does 99 indicate?

Well, my bad! I ran across another PRC class that had a feat that was supposed to affect critical attack threat rolls. Realizing that this might help me with #2, I looked to see how it was implemented and discovered that a) the PRC already has a rewritten combat engine (which both N-S and Drammel said would be necessary to do this right), and b) it already implements the Warblade feats for #2 and #3.  Drammel's idea of a Weapon Specialization proficiency feat has helped me with #5, and I think I've figured out as much as I need to for #6.

That leaves me with #4 (which I still haven't looked at any further) and some questions about how the PRC combat engine implements Uncanny Dodge, Improved Uncanny Dodge, etc. (which Warblade is also supposed to get). I've found a couple of what currently look to me like errors in the code; if they still look like errors after I think about it some more, I'll ask about it. Is here the best place?

[william_iii]

So how to implemented the Battle Mastery feat? It still seems not work now